Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update install manifest for aeraki #336

Closed
wants to merge 1 commit into from
Closed

update install manifest for aeraki #336

wants to merge 1 commit into from

Conversation

tanjunchen
Copy link
Member

What this PR does / Why we need it:

Pre-Submission Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing April 19, 2023 06:28
@zhaohuabing
Copy link
Member

@tanjunchen why we need this?

@tanjunchen
Copy link
Member Author

/retest

@tanjunchen
Copy link
Member Author

@tanjunchen why we need this?

@zhaohuabing

  1. Fix the bug that .Release.Namespace does not exist，refer to https://github.com/aeraki-mesh/aeraki/pull/336/files#diff-43173311cbcbb96cd0467f3399e82b42a7ac4bfbda0a5697de6e5260c33389e0L22
  2. According to https://github.com/istio/istio/blob/master/manifests/charts/base/templates/clusterrolebinding.yaml#L9 We can add namespace for Charts yaml files

zhaohuabing
zhaohuabing reviewed Apr 19, 2023
View reviewed changes
k8s/aeraki.yaml
@@ -118,7 +118,7 @@ kind: Role
metadata:
labels:
app: aeraki
name: aeraki
name: aeraki-${AERAKI_NAMESPACE}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to change the name?

Copy link
Member Author

@tanjunchen tanjunchen Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary, for installing multiple aeraki on the same cluster, this should be modified

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to use the same name for multiple Aeraki deployments since they're in different namespaces.

Copy link
Member Author

@tanjunchen tanjunchen Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing aeraki in different namespace, aeraki failed to start.
Refer to the istio document, it is recommended to use different clusterrole and clusterrolebinding.

@zhaohuabing
Copy link
Member

Hold this until we have a clear design how multi-tenants would work.

@zhaohuabing
Copy link
Member

This PR is related to #330

@stale
Copy link

stale bot commented Jun 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 22, 2023
@stale stale bot closed this Jun 29, 2023
@tanjunchen
Copy link
Member Author

/reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing left review comments

Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjunchen @zhaohuabing